Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: add non-null check to a recently merged builtin overload #95782

Merged
merged 1 commit into from
Jan 25, 2023
Merged

builtins: add non-null check to a recently merged builtin overload #95782

merged 1 commit into from
Jan 25, 2023

Conversation

yuzefovich
Copy link
Member

Fixes: #95671.

Release note: None

@yuzefovich yuzefovich requested review from msirek and a team January 24, 2023 18:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

msirek
msirek approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 25, 2023

Build succeeded:

@craig craig bot merged commit 0f5863a into cockroachdb:master Jan 25, 2023
@yuzefovich yuzefovich deleted the fix-builtin branch January 25, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msirek msirek msirek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest/sqlsmith: missing non-null check in crdb_internal.num_inverted_index_entries
3 participants
@yuzefovich @cockroach-teamcity @msirek