cdc: add transformations to create changefeed telemetry #95751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Previously, there were no telemetry events emitted to track the usage of
changefeed transformations. This change adds the `transformation` field
to the `CREATE CHANGEFEED` telemetry log event to track that. Example:
```
{
"Timestamp": 1674574083953989000, "EventType": "create_changefeed",
"Description": "CREATE CHANGEFEED INTO 'gcpubsub://testfeed?region=testfeedRegion' AS SELECT b FROM foo",
"SinkType": "gcpubsub", "NumTables": 1, "Resolved": "no", "IsTransformation": true
}
```
Epic: CRDB-17161
Closes: cockroachdb#95126
Release note: None
jayshrivastava
force-pushed
the
transformations-telemetry
branch
from
4af35d5 to
974177e
Compare
jayshrivastava
requested review from
shermanCRL
and removed request for
a team
miretskiy
approved these changes
Jan 24, 2023
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were no telemetry events emitted to track the usage of changefeed transformations. This change adds the
transformationfield to theCREATE CHANGEFEEDtelemetry log event to track that. Example:Epic: CRDB-17161
Closes: #95126
Release note: None