release-22.2: sql/catalog/schemaexpr: fix default expression assignment casts #95666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #95459.
/cc @cockroachdb/release
In #95398, casts were added to default expressions during backfills when
the default expression's type was not equivalent to the target column's
type. This commit fixes two minor bugs with the previous fix:
they had different families. Assignment casts must be added for
non-identical types with the same family. For example, a
TEXT
default expression must be assignment cast to a
CHAR(1)
column,even though they are both in the string family.
different behavior. For example, an assignment cast will error when
casting
TEXT
toCHAR(1)
if the string has a length greater thanone.
Some tests were added to show that default column backfills behave
consistently with Postgres.
Informs #93398
Epic: None
Release note: None
Release justification: Amendment to a recently merged backport.