ci: publish latest-master-build docker image
#95444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, our automation published latest docker images using `latest-v2x.x-build` tag. External automation that tracked the master branch would need to update the tag, when we change the version. This PR adds an extra step to tag the master branch builds with `latest-master-build` docker tag. Epic: none Release note: None
rail
added
C-enhancement
|
This change is |
srosenberg
reviewed
Jan 18, 2023
| @@ -55,6 +55,10 @@ if [[ -n "${release_branch}" ]] ; then | |||
| log_into_gcloud | |||
| gcloud container images add-tag "${gcr_repository}:${build_name}" "${gcr_repository}:latest-${release_branch}-build" | |||
| fi | |||
| if [[ "$TC_BUILD_BRANCH" == "master" ]]; then | |||
| log_into_gcloud | |||
| gcloud container images add-tag "${gcr_repository}:${build_name}" "${gcr_repository}:latest-master-build" | |||
There was a problem hiding this comment.
Don't we also need to remove the label from the previous push? There should always be at most one image with this tag, right?
There was a problem hiding this comment.
AFAIK, this push replaces all previously published tags with the same name. This is the same logic we use for latest-v23.1-build tag.
There was a problem hiding this comment.
Indeed. It's a property of container repositories that a given tag can be on only one image in a repository at a time.
There was a problem hiding this comment.
Thanks! I think I was regressing to this incantation which we had to use for updating the "latest" label after a new AMI was created,
gcloud compute images remove-labels $IMAGE --labels="latest"`
jlinder
approved these changes
Jan 18, 2023
|
bors r=jlinder |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our automation published latest docker images using
latest-v2x.x-buildtag. External automation that tracked the master branch would need to update the tag, when we change the version.This PR adds an extra step to tag the master branch builds with
latest-master-builddocker tag.Epic: none
Release note: None