Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: coldataext: remove an allocation in production builds for arrays #95408

Merged
merged 1 commit into from
Jan 18, 2023
Merged

release-22.1: coldataext: remove an allocation in production builds for arrays #95408

merged 1 commit into from
Jan 18, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 18, 2023 •
edited by yuzefovich
Loading

Backport 1/1 commits from #95400 on behalf of @yuzefovich.

/cc @cockroachdb/release

This commit makes it so that we only perform assertions in the datum vec in the test builds. In particular, this allows us to remove an allocation for each array object being set (which happens in tree.DArray.ResolvedType where we construct an array type on demand). I was just looking at a heap profile where this allocation accounted for 7% of all allocations.

Epic: None

Release note: None

Release justification: low risk performance fix.

@yuzefovich
coldataext: remove an allocation in production builds for arrays
113faed 
This commit makes it so that we only perform assertions in the datum vec
in the test builds. In particular, this allows us to remove an
allocation for each array object being set (which happens in
`tree.DArray.ResolvedType` where we construct an array type on demand).
I was just looking at a heap profile where this allocation accounted for
7% of all allocations.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 18, 2023 00:42
@blathers-crl blathers-crl bot requested a review from cucaroach January 18, 2023 00:42
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-95400 branch from c8444df to 113faed Compare January 18, 2023 00:42
@blathers-crl
Copy link
Author

blathers-crl bot commented Jan 18, 2023 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from DrewKimball January 18, 2023 00:42
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 18, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

DrewKimball
DrewKimball approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)

@yuzefovich yuzefovich merged commit 095a854 into release-22.1 Jan 18, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-22.1-95400 branch January 18, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewKimball DrewKimball DrewKimball approved these changes

@cucaroach cucaroach Awaiting requested review from cucaroach cucaroach is a code owner automatically assigned from cockroachdb/sql-queries

Assignees

@yuzefovich yuzefovich

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @DrewKimball @yuzefovich