roachtest: fix zipping of artifacts to include other zips #95374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When artifacts are zipped in preparation for being published to
TeamCity, other zip files are skipped. The idea is that we won't try
to recursively zip artifacts.zip itself, or debug.zip, which is
published separately. However, some tests (notably,
tpchvec
)download their own zip files in the
logs
directory so that they'llbe available for analysis when a test fails.
While there was an intention to skip only top-level zip files (as
indicated by existing comments), the code itself would skip any zip
files found in the
logs
directory. This commit updates the zippinglogic to skip only toplevel zip files, allowing tests to write their
own zip files to the
logs
directory and have them available forinspection later.
Release note: None.Backport:
Please see individual PRs for details.
/cc @cockroachdb/release