server: fix UserSQLRoles to account for global privileges

[rafiss]

Epic: None
Release note (bug fix): DB Console features that check for the
VIEWACTIVITYREDACTED privilege now also account for global privileges.

[cockroach-teamcity]

This change is 

[maryliag]

Nice!
Can you also add a test on

cockroach/pkg/server/user_test.go

Line 77 in b8eee78

func TestSQLRolesAPI(t *testing.T) {

that would have got this issue?

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kpatron-cockroachlabs)

[rafiss]

@maryliag can you point me to where this endpoint is used in the frontend? i'm wondering since my change reduces the set of privileges that are returned in the map. e.g., it no longer includes VALID UNTIL or PASSWORD, and it doesn't include most of the NOXYZ options. the privileges it returns are now just these ones:

cockroach/pkg/sql/privilege/privilege.go

Line 129 in 0e835dd

GlobalPrivileges = List{ALL, BACKUP, RESTORE, MODIFYCLUSTERSETTING, EXTERNALCONNECTION, VIEWACTIVITY, VIEWACTIVITYREDACTED, VIEWCLUSTERSETTING, CANCELQUERY, NOSQLLOGIN, VIEWCLUSTERMETADATA, VIEWDEBUG, EXTERNALIOIMPLICITACCESS}

[maryliag]

Basically we call refreshUser like this,
which then updates our redux layer, then we can use selectors to got some of the specific roles we care about, for now we only care about roles VIEWACTIVITYREDACTED and ADMIN,
which then can be used in places like here and here (this example is hiding statement diagnostics if the user has VIEWACTIVITYROLE)

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kpatron-cockroachlabs and @rafiss)

---

pkg/server/user_test.go line 114 at r2 (raw file):

	require.Equal(t, expRoles, res.Roles)

	// Remove one role from non-admin user.

can you also add an example with revoke global privilege?

[rafiss]

i see, thanks for explaining! RFAL

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @kpatron-cockroachlabs and @maryliag)

---

pkg/server/user_test.go line 114 at r2 (raw file):

Previously, maryliag (Marylia Gutierrez) wrote…

can you also add an example with revoke global privilege?

done

[maryliag]

Reviewed 1 of 2 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @kpatron-cockroachlabs)

[rafiss]

tftr! flake was #95140 which was resolved in a later PR

bors r=maryliag

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)