Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingest: add a replication lag metric #95248

Merged
merged 1 commit into from
Jan 18, 2023
Merged

streamingest: add a replication lag metric #95248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/ccl/streamingccl/streamingest/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ var (
Measurement: "Resolved Spans",
Unit: metric.Unit_COUNT,
}
metaFrontierLagSeconds = metric.Metadata{
Name: "streaming.frontier_lag_seconds",
Help: "Time the replication frontier lags",
Measurement: "Seconds",
Unit: metric.Unit_SECONDS,
}
metaJobProgressUpdates = metric.Metadata{
Name: "streaming.job_progress_updates",
Help: "Total number of updates to the ingestion job progress",
Expand All @@ -115,6 +121,7 @@ type Metrics struct {
LatestDataCheckpointSpan *metric.Gauge
DataCheckpointSpanCount *metric.Gauge
FrontierCheckpointSpanCount *metric.Gauge
FrontierLagSeconds *metric.GaugeFloat64
}

// MetricStruct implements the metric.Struct interface.
Expand All @@ -139,6 +146,7 @@ func MakeMetrics(histogramWindow time.Duration) metric.Struct {
LatestDataCheckpointSpan: metric.NewGauge(metaLatestDataCheckpointSpan),
DataCheckpointSpanCount: metric.NewGauge(metaDataCheckpointSpanCount),
FrontierCheckpointSpanCount: metric.NewGauge(metaFrontierCheckpointSpanCount),
FrontierLagSeconds: metric.NewGaugeFloat64(metaFrontierLagSeconds),
}
return m
}
Expand Down
1 change: 1 addition & 0 deletions pkg/ccl/streamingccl/streamingest/stream_ingestion_frontier_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ func (sf *streamIngestionFrontier) maybeUpdatePartitionProgress() error {
sf.metrics.JobProgressUpdates.Inc(1)
sf.persistedHighWater = f.Frontier()
sf.metrics.FrontierCheckpointSpanCount.Update(int64(len(frontierResolvedSpans)))
sf.metrics.FrontierLagSeconds.Update(timeutil.Since(sf.persistedHighWater.GoTime()).Seconds())

return nil
}
4 changes: 4 additions & 0 deletions pkg/ts/catalog/chart_catalog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,10 @@ var charts = []sectionDescription{
Title: "Frontier Checkpoint Span Count",
Metrics: []string{"streaming.frontier_checkpoint_span_count"},
},
{
Title: "Frontier Lag",
Metrics: []string{"streaming.frontier_lag_seconds"},
},
{
Title: "Job Progress Updates",
Metrics: []string{"streaming.job_progress_updates"},
Expand Down