c2c: increase c2c roachtest workload flexibility #95191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbutler
requested review from
srosenberg and
renatolabs
and removed request for
a team
|
This change is |
msbutler
force-pushed
the
butler-c2c-bench
branch
from
ebcf9d5 to
2443daf
Compare
renatolabs
reviewed
Jan 13, 2023
msbutler
force-pushed
the
butler-c2c-bench
branch
from
2443daf to
a39a665
Compare
stevendanna
approved these changes
Jan 18, 2023
renatolabs
approved these changes
Jan 18, 2023
msbutler
force-pushed
the
butler-c2c-bench
branch
from
a39a665 to
4cf7a4f
Compare
|
TFTR! bors r=stevendanna, renatolabs |
|
Merge conflict. |
Previously in c2c roachtests, the foreground workload on the src cluster would run for a predefined amount of time, based on the expected initial scan time. But, if this estimated initial scan time wasn't accurate, the roachtest would not properly simulate c2c customer workload. E.g. if the initial scan actually took much longer than expected, the workload would finish before the initial scan! This patch removes the need to specify a duration for the src cluster workload. Instead, the goroutine running the workload will get cancelled at cutover time, determined by the `replicationTestSpec.additionalDuration` field, which specifies how long the workload should after the initial scan completes. This patch also adds additional logging which provides instructions for opening a sql session to the tenant and opening a tenant's dbconsole. Informs cockroachdb#89176 Release note: None
msbutler
force-pushed
the
butler-c2c-bench
branch
from
4cf7a4f to
73358d4
Compare
|
bors r=stevendanna, renatolabs |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in c2c roachtests, the foreground workload on the src cluster would run for a predefined amount of time, based on the expected initial scan time. But, if this estimated initial scan time wasn't accurate, the roachtest would not properly simulate c2c customer workload. E.g. if the initial scan actually took much longer than expected, the workload would finish before the initial scan!
This patch removes the need to specify a duration for the src cluster workload. Instead, the goroutine running the workload will get cancelled at cutover time, determined by the
replicationTestSpec.additionalDurationfield, which specifies how long the workload should after the initial scan completes.This patch also adds additional logging which provides instructions for opening a sql session to the tenant and opening a tenant's dbconsole.
Informs #89176
Release note: None