sql/schemachanger: downgrade log warning when statement is not supported #95151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, we'd log a warning with a scary file path when building any opaque statement which is not supported by the declarative schema changer: ``` I230112 15:56:38.184048 1797 sql/schemachanger/scbuild/build.go:39 ⋮ [n1,client=127.0.0.1:50565,user=root] 86 building declarative schema change targets for EXPERIMENTAL CHANGEFEED W230112 15:56:38.184280 1797 runtime/panic.go:884 ⋮ [n1,client=127.0.0.1:50565,user=root] 87 failed building declarative schema change targets for EXPERIMENTAL CHANGEFEED with error: ‹*tree.CreateChangefeed not implemented in the new schema changer› ``` Epic: None Relates to cockroachdb#95053 Release note: None
|
This change is |
chengxiong-ruan
approved these changes
Jan 12, 2023
|
TFTR! |
|
blathers backport 22.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, we'd log a warning with a scary file path when building any opaque statement which is not supported by the declarative schema changer:
Epic: None
Relates to #95053
Release note: None