changefeedccl: give notice when metrics_label set without child_metrics #94948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miretskiy
approved these changes
Jan 9, 2023
|
This change is |
samiskin
force-pushed
the
cdc-metrics-label-notice
branch
from
eeba9c8 to
9fbd24f
Compare
Resolves cockroachdb#75682 Surfaces a notice of ``` server.child_metrics.enabled is set to false, metrics will only be published to the '<scope>' label when it is set to true" ``` When child_metrics setting isn't enabled during changefeed creation Release note (enterprise change): Changefeeds created/altered with a metrics_label set while server.child_metrics.enabled is false will now provide the user a notice upon creation. <what was there before: Previously, ...> <why it needed to change: This was inadequate because ...> <what you did about it: To address this, this patch ...>
samiskin
force-pushed
the
cdc-metrics-label-notice
branch
from
9fbd24f to
f5a5b4b
Compare
|
bors r+ |
|
bors single on |
|
bors r- |
|
Canceled. |
|
bors r+ single off |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: |
|
bors r- |
1 similar comment
|
bors r- |
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75682
Surfaces a notice of
When child_metrics setting isn't enabled during changefeed creation
Release note (enterprise change): Changefeeds created/altered with a metrics_label set while server.child_metrics.enabled is false will now provide the user a notice upon creation.