roachtest: fix multitenant-upgrade expected error #94947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cockroachdb#94669, we changed usages of `host cluster` to `storage cluster` because `host cluster` is specific to `CC Serverless`. This change updates the expected error in `multitenant-upgrade` and some other usages of `host cluster`. Epic: none Release note: None Closes cockroachdb#94748
healthy-pod
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
ajstorm
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Thanks for getting to this one so quickly!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @smg260 and @srosenberg)
|
TFTR! bors r=ajstorm |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r=ajstorm single on |
|
bors r- |
|
Canceled. |
|
bors single on |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #94669, we changed usages of
host clustertostorage clusterbecausehost clusteris specific toCC Serverless.This change updates the expected
error in
multitenant-upgradeand some other usages ofhost cluster.Epic: none
Release note: None
Closes #94748