Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: Fix flaky test #94864

Merged
merged 1 commit into from
Jan 11, 2023
Merged

changefeedccl: Fix flaky test #94864

merged 1 commit into from
Jan 11, 2023

Conversation

miretskiy
Copy link
Contributor

Disable enterprise and webhook sink in TestChangefeedOnlyInitialScan test since these sink (or at least our test implementations) are too slow to process many messages.

Fixes #94816

Release note: None

Disable enterprise and webhook sink in TestChangefeedOnlyInitialScan
test since these sink (or at least our test implementations)
are too slow to process many messages.

Fixes cockroachdb#94816

Release note: None
@miretskiy miretskiy requested a review from a team as a code owner January 6, 2023 22:15
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@HonoreDB HonoreDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jayshrivastava)

@miretskiy
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 10, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

@miretskiy
Copy link
Contributor Author

bors r+ single on

@craig
Copy link
Contributor

craig bot commented Jan 11, 2023

Build succeeded:

@craig craig bot merged commit 32ef463 into cockroachdb:master Jan 11, 2023
@rail
Copy link
Member

rail commented Jan 11, 2023

bors r-

@rail
Copy link
Member

rail commented Jan 11, 2023

Too late :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedOnlyInitialScan failed
4 participants