Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: bootstrap: add string representation of initial values #94794

Merged
merged 1 commit into from
Jan 6, 2023
Merged

release-22.1: bootstrap: add string representation of initial values #94794

merged 1 commit into from
Jan 6, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jan 5, 2023 •
edited
Loading

This commit adds InitialValuesToString and InitialValuesFromString which convert KV datums and KV split keys from a MetadataSchema to a string representation and vice-versa. The tenant prefix is omitted from the string representation.

This functionality exists to allow bootstrapping clusters using the values and splits as generated by an earlier cockroach binary.

Informs #94773.

Release note: None
Release justification: test-only change

@blathers-crl
Copy link

blathers-crl bot commented Jan 5, 2023 •
edited by postamar
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar force-pushed the cherry-picked-94774-on-221 branch from d2095f8 to 240eef0 Compare January 6, 2023 17:46
@postamar postamar marked this pull request as ready for review January 6, 2023 17:47
@postamar postamar requested a review from a team January 6, 2023 17:47
fqazi
fqazi approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @postamar)

bootstrap: add string representation of initial values
2ae9c65 
This commit adds InitialValuesToString and InitialValuesFromString which
convert KV datums and KV split keys from a MetadataSchema to a string
representation and vice-versa. The tenant prefix is omitted from the
string representation.

This functionality exists to allow bootstrapping clusters using the
values and splits as generated by an earlier cockroach binary.

Informs cockroachdb#94773.

Release note: None
@postamar postamar force-pushed the cherry-picked-94774-on-221 branch from 240eef0 to 2ae9c65 Compare January 6, 2023 19:11
@postamar postamar merged commit 1e03d0c into cockroachdb:release-22.1 Jan 6, 2023
@postamar postamar deleted the cherry-picked-94774-on-221 branch January 6, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi fqazi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@postamar @cockroach-teamcity @fqazi