split: init replica lb splitter with global rand #94754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
230105.randsource-mem
branch
from
03b2d9a to
d64bc43
Compare
erikgrinaker
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
I'm assuming the default source is seeded here?
Lines 54 to 55 in 9351196
In cockroachdb#93838 we started initializing a new seeded rand for use in the load based splitter's reservoir sampling algorithm. Previously, the splitter was initialized using the global rand. `rand.Source` heap allocates on init approximately 4kb. When initialized per-replica, this is problematic as nodes scale to large replica counts. This patch replaces initializing a new random source per-replica with using the global rand instead. resolves: cockroachdb#94752 resolves: cockroachdb#94737 Release note: None
kvoli
force-pushed
the
230105.randsource-mem
branch
from
d64bc43 to
891e7a0
Compare
Yeah - perhaps a misleading title/commit msg. I've updated it to be more specific. |
kvoli
changed the title
|
bors r=erikgrinaker TYFTR |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #93838 we started initializing a new seeded rand for use in the load
based splitter's reservoir sampling algorithm. Previously, the splitter
was initialized using the global rand.
rand.Sourceheap allocates on init approximately 4kb. When initializedper-replica, this is problematic as nodes scale to large replica counts.
This patch replaces initializing a new random source per-replica with
using the global rand instead.
This removes the heap allocation. This is shown below running
kv/splits/nodes=3/quiesce=true(not at identical replica counts in the test,the proportions are the important part).
before:
after:
resolves: #94752
resolves: #94737
Release note: None