Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: move LoadAndReconcileReplicas to kvstorage #94131

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Dec 22, 2022

Mechanical using GoLand.

Next steps are starting to add a datadriven testing framework
so that functionality can be exercised when it moves or is added here,
i.e. #93247.

Epic: none
Release note: None

Epic: none
Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg marked this pull request as ready for review December 22, 2022 10:38
@tbg tbg requested a review from a team December 22, 2022 10:38
@tbg tbg requested review from a team as code owners December 22, 2022 10:38
@tbg tbg requested a review from pav-kv December 22, 2022 10:38
@tbg
Copy link
Member Author

tbg commented Dec 22, 2022

This is identical to #93944 (comment), which was closed by craig when I merged the kvstorage branch. Still working on my git-machete skills...

Mechanical using GoLand.

Next steps are starting to add a datadriven testing framework
so that functionality can be exercised when it moves or is added here,
i.e. cockroachdb#93247.

Epic: none
Release note: None
@tbg
Copy link
Member Author

tbg commented Dec 22, 2022

bors r=pavelkalinnikov
TFTR!

@craig
Copy link
Contributor

craig bot commented Dec 22, 2022

Build succeeded:

@craig craig bot merged commit d0823ba into cockroachdb:master Dec 22, 2022
@tbg tbg deleted the mv-store-start branch December 22, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants