sql: change RequireActiveIndex to IncludeNonActiveIndex
#94046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of a `bool` field should encode the common case. The common case for index resolution should be to include only active indexes. So this patch changes `RequireActiveIndex` (`false` is non-common case) to `IncludeNonActiveIndex` (`false` becomes common case). Release note: None
|
This change is |
chengxiong-ruan
approved these changes
Dec 21, 2022
craig bot
pushed a commit
that referenced
this pull request
Dec 21, 2022
94048: catalog: properly propagate flags r=chengxiong-ruan a=knz First commit from #94046. Needed for #93644. Without this patch, it's still not possible to look up offline tables and non-active indexes. Release note: None Epic: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #93942.
The default value of a
boolfield should encode the common case. The common case for index resolution should be to include only active indexes. So this patch changesRequireActiveIndex(falseis non-common case) toIncludeNonActiveIndex(falsebecomes common case).Release note: None
Informs: #94128
Epic: CRDB-22701