Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: refresh nodes on tenants #93914

Merged
merged 1 commit into from
Dec 19, 2022
Merged

ui: refresh nodes on tenants #93914

merged 1 commit into from
Dec 19, 2022

Conversation

matthewtodd
Copy link
Contributor

Part of #89949

Now that we can show meaningful region information for tenants, we need to actually trigger the fetching of that information.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Part of #89949

Now that we can show meaningful region information for tenants, we need
to actually trigger the fetching of that information.

Release note: None
@matthewtodd matthewtodd requested a review from a team December 19, 2022 16:54
@matthewtodd matthewtodd marked this pull request as ready for review December 19, 2022 16:54
@matthewtodd matthewtodd requested a review from a team December 19, 2022 16:54
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 6 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)


pkg/ui/workspaces/cluster-ui/src/statementsPage/statementsPage.tsx line 347 at r1 (raw file):

    this.props.refreshUserSQLRoles();
    this.props.refreshNodes();
    if (!this.props.isTenant) {

nit: since there's nothing in between can we put these 2 conditions into 1 if?


pkg/ui/workspaces/cluster-ui/src/statementsPage/statementsPage.tsx line 389 at r1 (raw file):

    this.updateQueryParams();
    this.props.refreshNodes();
    if (!this.props.isTenant) {

same here

@matthewtodd
Copy link
Contributor Author

TFTR, @xinhaoz!

Agreed on collapsing the ifs, will do that in a follow-on branch just now to avoid another CI cycle here.

bors r+

@matthewtodd
Copy link
Contributor Author

Follow-on PR collapsing the ifs is #93921.

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Dec 19, 2022

Build succeeded:

@craig craig bot merged commit 91fbbad into cockroachdb:master Dec 19, 2022
@matthewtodd matthewtodd deleted the ui-tenant-nodes-fixes branch December 19, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants