-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-and-publish-patched-go: upgrade from 1.19.1 to 1.19.4 #93852
build-and-publish-patched-go: upgrade from 1.19.1 to 1.19.4 #93852
Conversation
e2a302a
to
f38ceda
Compare
We probably ought to backport this. |
This also picked up a run of |
f38ceda
to
24c20e1
Compare
Can you follow the directions for upgrading Go versions in |
24c20e1
to
f5d21f5
Compare
This upgrade picks up compiler fixes, in particular related to generic data structures. It also picks up security fixes. Release note: None
f5d21f5
to
ce39332
Compare
@rickystewart I'll leave the last two steps for this to get an LGTM. I think it's ready. |
As far as I can tell, for pebble, we just list the major version in CI. |
bors r+ |
Build succeeded: |
don't we want this in 22.2 too? |
blathers backport 22.2 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ce39332 to blathers/backport-release-22.2-93852: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This picks up a mix of security and compiler fixes. The compiler fixes I'm interested in relate to generic data structures, but the other fixes seem worthwhile too.
build/teamcity/internal/release/build-and-publish-patched-go/impl.sh
with the new version and adjust SHA256 sums as necessary.Internal / Release / Build and Publish Patched Go
build configuration in TeamCity with your latest version of the script above. This will print out the new URL's and SHA256 sums for the patched Go that you built above.WORKSPACE
undergo_download_sdk
. You may need to bump rules_go. Also edit the filenames listed insdks
and update all the hashes to match what you built in the step above../dev generate bazel
to refreshdistdir_files.bzl
, thenbazel fetch @distdir//:archives
to ensure you've updated all hashes to the correct value.builder.sh
accordingly (source).go-version-check.sh
(source), unless bumping to a new patch release.go.mod
.bootstrap-debian.sh
(source).golang:<old_version>
andgo<old_version>
).builder.dockerImage
parameter in the TeamCityCockroach
andInternal
projects.Epic: None
Release note: None