nstree: fix Catalog namespace validation error messages #93726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @postamar)
pkg/sql/catalog/nstree/catalog.go line 260 at r1 (raw file):
switch ne.GetID() { case descpb.InvalidID: return errors.New("zero descriptor ID")
I always associate invalid with zero, but both languages are fine. Don't feel strongly about it either way.
fqazi
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2.
Reviewable status:
|
Thanks for your review! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
These mention draining names, but draining names have been removed two major versions ago. Fixes cockroachdb#93724. Release note: None
|
bors r+ 4th time's the charm |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These mention draining names, but draining names have been removed two major versions ago.
Fixes #93724.
Release note: None