cli,cliccl: move some mt commands to cliccl #93618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This is blocking #93477 |
ajwerner
changed the title
knz
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/ccl/cliccl/mt_proxy.go line 99 at r1 (raw file):
func initLogging(cmd *cobra.Command) (ctx context.Context, stopper *stop.Stopper, err error) { // Remove the default store, which avoids using it to set up logging.
This comment is now out of place.
Part of cockroachdb#91714 Epic: none Release note: None
ajwerner
force-pushed
the
ajwerner/move-ccl-mt-commands-to-ccl
branch
from
0bc1f6d to
3bde92a
Compare
ajwerner
commented
Dec 14, 2022
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/ccl/cliccl/mt_proxy.go line 99 at r1 (raw file):
Previously, knz (Raphael 'kena' Poss) wrote…
This comment is now out of place.
Done.
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #91714
Epic: none
Release note: None