catkv,*: remove catkv.Direct interface #93611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
postamar
force-pushed
the
bye-bye-direct
branch
from
2fc77bc to
b0b3438
Compare
postamar
changed the title
postamar
force-pushed
the
bye-bye-direct
branch
from
b0b3438 to
9d1bb9e
Compare
postamar
requested review from
benbardin,
stevendanna and
ajwerner
and removed request for
a team,
benbardin and
stevendanna
ajwerner
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 5 of 5 files at r2, 2 of 2 files at r3, 12 of 12 files at r4, 2 of 2 files at r5, 1 of 1 files at r6, 31 of 31 files at r7, 6 of 6 files at r8, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar)
|
Thanks for the review! CI is unhappy due to an unrelated flaky test. bors r+ |
|
Merge conflict. |
postamar
force-pushed
the
bye-bye-direct
branch
from
9d1bb9e to
df57e9a
Compare
|
bors r+ |
|
Build failed: |
added 2 commits
December 14, 2022 22:27
This commit replaces it with the GetAllFromStorageUnvalidated method on descs.Collection Release note: None
This commit transfers the ownership of the node's catkv.SystemDatabaseCache singleton from the descs.CollectionFactory to the lease.Manager. It also replaces catkv.Direct usage in the lease package by catkv.CatalogReader calls. Release note: None
added 7 commits
December 14, 2022 22:27
This commit removes the MaybeGetDescriptorByIDUnvalidated method from the catkv.Direct interface. Release note: None
These methods are replaced by new functions in the descs package which operate on the descs.Collection. Release note: None
This commit removes dead code. Release note: None
Release note: None
This can now be replaced by calls to descs.Collection methods. Informs cockroachdb#64089. Release note: None
This removes the last usage of uncached catkv.CatalogReader outside of testing. Release note: None
This commit fixes a bug in which persisted catalog changes were not visible in the results of this descs.Collection's method when the transation already involved a full catalog scan before those changes. Release note: None
postamar
force-pushed
the
bye-bye-direct
branch
from
df57e9a to
f62d2aa
Compare
|
The flake wasn't unrelated and in fact the workload test found a legit bug! I'm grateful for it. |
|
bors r+ |
|
Build failed: |
|
This time it really is an unrelated flake. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #64089.
Release note: None