Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: add version gate for system privs during DROP ROLE #93435

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 12, 2022

Release justification: bug fix

Epic: None

Release note (bug fix): Fixed a bug that could happen when dropping a
user/role before the upgrade to v22.2 was finalized.

@rafiss rafiss requested review from ecwall and a team December 12, 2022 16:36
@blathers-crl
Copy link

blathers-crl bot commented Dec 12, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ecwall)

@rafiss rafiss force-pushed the fix-drop-role-system-priv branch from 95eb136 to fd50e4e Compare December 12, 2022 17:11
Release note (bug fix): Fixed an error that could occur when dropping a
user/role before the upgrade to v22.2 was finalized.
@rafiss rafiss force-pushed the fix-drop-role-system-priv branch from fd50e4e to 8681d24 Compare December 12, 2022 21:31
@rafiss rafiss merged commit ccce779 into cockroachdb:release-22.2 Dec 13, 2022
@rafiss rafiss deleted the fix-drop-role-system-priv branch December 13, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants