Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: move replicaAppBatch to replica_app_batch.go #93237

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Dec 8, 2022

For #75729 we will want to work on replicaAppBatch and decompose it into
a new type appBatch around which replicaAppBatch can be layered.

As a first baby step, move appbatch-related code to its own
file to physically separate it from the apply.StateMachine.

This is 100% mechanical (using Goland's refactoring tools).

Epic: CRDB-220
Release note: None

@tbg tbg requested a review from a team as a code owner December 8, 2022 08:45
@tbg tbg requested a review from pav-kv December 8, 2022 08:45
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg force-pushed the mv-replica-app-batch branch from 6f99b7c to a777332 Compare December 8, 2022 09:50
For cockroachdb#75729 we will want to work on replicaAppBatch and decompose it into
a new type appBatch around which replicaAppBatch can be layered.

As a first baby step, move appbatch-related code to its own
file to physically separate it from the `apply.StateMachine`.

This is 100% mechanical (using Goland's refactoring tools).

Release note: None
@tbg tbg force-pushed the mv-replica-app-batch branch from a777332 to 9983430 Compare December 8, 2022 09:51
@tbg
Copy link
Member Author

tbg commented Dec 8, 2022

bors r=pavelkalinnikov

@craig
Copy link
Contributor

craig bot commented Dec 8, 2022

Build succeeded:

@craig craig bot merged commit 48966e9 into cockroachdb:master Dec 8, 2022
@tbg tbg deleted the mv-replica-app-batch branch December 8, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants