rttanalysis: don't count leasing the database desc #93153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
force-pushed
the
rtt-analysis
branch
3 times, most recently
from
28e426c to
d858d35
Compare
ajwerner
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
andreimatei
force-pushed
the
rtt-analysis
branch
from
d858d35 to
bea7029
Compare
andreimatei
commented
Dec 14, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
andreimatei
commented
Dec 14, 2022
There was a problem hiding this comment.
bors r-
Reviewable status:
|
Canceled. |
andreimatei
force-pushed
the
rtt-analysis
branch
from
bea7029 to
233416f
Compare
A bunch of rtt-analysis tests were counting a request for leasing the database descriptor. This is not interesting. This patch makes the test framework lease it first through a "USE" statement. The number of KV requests required for leasing is currently mis-counted. We count 1, but in reality it's 4. A different patch will correct the miscounting that, at which point that would be too significant for the tests. Release note: None Epic: None
It's useful to turn it off when you want to see if you're chaning any numbers. Release note: None
andreimatei
force-pushed
the
rtt-analysis
branch
from
233416f to
21c408f
Compare
andreimatei
commented
Dec 14, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of rtt-analysis tests were counting a request for leasing the database descriptor. This is not interesting. This patch makes the test framework lease it first through a "USE" statement.
The number of KV requests required for leasing is currently mis-counted. We count 1, but in reality it's 4. A different patch will correct the miscounting that, at which point that would be too significant for the tests.
Release note: None
Epic: None