Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: server: introduce COCKROACH_FALLBACK_SPANCONFIG_NUM_REPLICAS_OVERRIDE #93093

Conversation

irfansharif
Copy link
Contributor

It controls what replication factor is used for ranges with no explicit span configs set. This is a backportable form of the spanconfig.store.fallback_config_override we added in #92466.

Release note: None
Release justification: Introduce an env var that would've come in handy in an internal escalation -- it allows users to control what replication factor is used for ranges not explicitly referenced by zone configs. Without this env var, the value used is a hardcoded default of 3.

@irfansharif irfansharif requested review from tbg and arulajmani December 5, 2022 23:18
@irfansharif irfansharif requested review from a team as code owners December 5, 2022 23:18
@blathers-crl
Copy link

blathers-crl bot commented Dec 5, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a release note telling users about the env var and intended usage? Or are we intentionally adding it "secretly"?

cc @ricardocrdb

It controls what replication factor is used for ranges with no explicit
span configs set. This is a backportable form of the
spanconfig.store.fallback_config_override we added in cockroachdb#92466.

Release note: None
@irfansharif irfansharif force-pushed the 221205.22.1-spanconfig-override branch from f9a3981 to f2a8856 Compare December 6, 2022 23:19
@irfansharif
Copy link
Contributor Author

Intentionally adding it without a release note.

@irfansharif irfansharif merged commit 4b95005 into cockroachdb:release-22.1 Dec 7, 2022
@irfansharif irfansharif deleted the 221205.22.1-spanconfig-override branch December 7, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants