Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: alias tree.ParamTypes as []tree.ParamType #93080

Merged
merged 1 commit into from
Dec 9, 2022
Merged

sql: alias tree.ParamTypes as []tree.ParamType #93080

merged 1 commit into from
Dec 9, 2022

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Dec 5, 2022

Epic: None

Release note: None

@mgartner mgartner requested a review from a team as a code owner December 5, 2022 21:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner closed this Dec 6, 2022
@mgartner mgartner deleted the param-types branch December 6, 2022 14:52
@mgartner mgartner restored the param-types branch December 7, 2022 21:55
@mgartner mgartner reopened this Dec 7, 2022
@mgartner mgartner requested a review from a team December 8, 2022 00:02
@mgartner
sql: alias tree.ParamTypes as []tree.ParamType
b56e6f5 
Epic: None

Release note: None
@mgartner mgartner requested a review from a team as a code owner December 8, 2022 14:49
@mgartner
Copy link
Collaborator Author

mgartner commented Dec 8, 2022

@chengxiong-ruan I reopened this and managed to get the linters passing. RFAL.

chengxiong-ruan
chengxiong-ruan approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!
Did you use a script? There are hundreds of this struct change :)

@mgartner
Copy link
Collaborator Author

mgartner commented Dec 9, 2022

It was a combination of search and replace regexes and elbow grease 😉

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 9, 2022

Build succeeded:

@craig craig bot merged commit 153448e into cockroachdb:master Dec 9, 2022
@mgartner mgartner deleted the param-types branch December 12, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengxiong-ruan chengxiong-ruan chengxiong-ruan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgartner @cockroach-teamcity @chengxiong-ruan