-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix link for index from insights #92953
Conversation
fe78266
to
553fa40
Compare
553fa40
to
35b996d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick question
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx
line 333 at r1 (raw file):
title: insightsTableTitles.details(), cell: (item: InsightRecommendation) => descriptionCell(item, showQuery, disableStmtLink, hideAction),
why do we add hideAction
here?
35b996d
to
1045cee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @THardy98)
pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx
line 333 at r1 (raw file):
Previously, THardy98 (Thomas Hardy) wrote…
why do we add
hideAction
here?
this is the flag for "isCockroachCloud". I can rename to make it more clear
1045cee
to
a72d2ce
Compare
Previously, the link to index details on the drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console. Fix cockroachdb#92944 Release note (bug fix): Fix link to index details on drop index insights on CC Console.
a72d2ce
to
700649c
Compare
TFTR! |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 700649c to blathers/backport-release-22.2-92953: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, the link to index details on the
drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console.
Fix #92944
Release note (bug fix): Fix link to index details on drop index insights on CC Console.