Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix link for index from insights #92953

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Dec 2, 2022

Previously, the link to index details on the
drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console.

Fix #92944

Release note (bug fix): Fix link to index details on drop index insights on CC Console.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag marked this pull request as ready for review December 2, 2022 20:44
@maryliag maryliag requested a review from a team December 2, 2022 20:44
Copy link

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

just a quick question

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)


pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx line 333 at r1 (raw file):

      title: insightsTableTitles.details(),
      cell: (item: InsightRecommendation) =>
        descriptionCell(item, showQuery, disableStmtLink, hideAction),

why do we add hideAction here?

Copy link
Contributor Author

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @THardy98)


pkg/ui/workspaces/cluster-ui/src/insightsTable/insightsTable.tsx line 333 at r1 (raw file):

Previously, THardy98 (Thomas Hardy) wrote…

why do we add hideAction here?

this is the flag for "isCockroachCloud". I can rename to make it more clear

Previously, the link to index details on the
drop index insights was using the URL format used by
DB Console only. This commit updates to use the correct
format when loading from CC Console.

Fix cockroachdb#92944

Release note (bug fix): Fix link to index details on drop
index insights on CC Console.
@maryliag
Copy link
Contributor Author

maryliag commented Dec 2, 2022

TFTR!
bors r+

@craig
Copy link
Contributor

craig bot commented Dec 2, 2022

Build succeeded:

@craig craig bot merged commit 865ad56 into cockroachdb:master Dec 2, 2022
@blathers-crl
Copy link

blathers-crl bot commented Dec 2, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 700649c to blathers/backport-release-22.2-92953: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken index details link for drop unused indexes
3 participants