leaktest: remove forced GC #92930
Merged
leaktest: remove forced GC #92930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Dec 2, 2022
The leaktest was forcing a GC, which is bizarre. Folklore has it that it was done for cockroachdb#61120, which in the meantime has been solved in other ways. This patch removes the unusual GC and hopes for the best. Release note: None Epic: None
andreimatei
force-pushed
the
small.leaktest-gc
branch
from
c561f57 to
56541cf
Compare
andreimatei
commented
Dec 12, 2022
There was a problem hiding this comment.
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @lunevalex)
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leaktest was forcing a GC, which is bizarre. Folklore has it that it was done for #61120, which in the meantime has been solved in other ways. This patch removes the unusual GC and hopes for the best.
Release note: None
Epic: None