Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: parser: retain comments #92844

Closed
wants to merge 2 commits into from

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 1, 2022

Backport 2/3 commits from #86968.

/cc @cockroachdb/release

Release justification: low risk fix
Epic: None


This commit adds a new array to the return value from the parser, which
contains the comments that were in the parsed SQL statement.

Previously, the parser (actually the scanner) removed comments that came
at the end of a statement from the raw sql that was returned along with
the parsed AST. This behavior is now removed.

Release note: None

This commit adds a new array to the return value from the parser, which
contains the comments that were in the parsed SQL statement.

Release note: None
@rafiss rafiss requested a review from jordanlewis December 1, 2022 18:40
@rafiss rafiss requested a review from a team as a code owner December 1, 2022 18:40
@blathers-crl
Copy link

blathers-crl bot commented Dec 1, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the parser (actually the scanner) removed comments that came
at the end of a statement from the raw sql that was returned along with
the parsed AST. This behavior is now removed.

Release note: None
@rafiss rafiss force-pushed the backport22.2-86968 branch from 310c783 to 5905ee5 Compare December 1, 2022 19:40
@rafiss rafiss closed this Dec 22, 2022
@rafiss rafiss deleted the backport22.2-86968 branch December 23, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants