Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: ux improvements #92765

Merged
merged 1 commit into from
Nov 30, 2022
Merged

ui: ux improvements #92765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
padding-right: 9px;
padding-left: 9px;
margin-right: -9px;
margin-left: -9px;
margin-left: 9px;
}

&__header {
Expand Down Expand Up @@ -157,3 +157,7 @@
font-weight: $font-weight--extra-bold;
color: $colors--neutral-8;
}

.row-spaced {
margin-top: 20px;
}
2 changes: 1 addition & 1 deletion pkg/ui/workspaces/cluster-ui/src/databaseTablePage/databaseTablePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,7 @@ export class DatabaseTablePage extends React.Component<
</SummaryCard>
</Col>
</Row>
<Row gutter={18}>
<Row gutter={18} className={cx("row-spaced")}>
<SummaryCard
className={cx(
"summary-card",
Expand Down
6 changes: 6 additions & 0 deletions pkg/ui/workspaces/cluster-ui/src/indexDetailsPage/indexDetailsPage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
&--row {
background-color: $adminui-white;
letter-spacing: 0.33px;
margin-left: 1px;
}
&--label {
font-family: $font-family--semi-bold;
Expand Down Expand Up @@ -136,3 +137,8 @@
text-decoration: underline;
}
}

.row-spaced {
margin-top: 20px;
}

9 changes: 6 additions & 3 deletions pkg/ui/workspaces/cluster-ui/src/indexDetailsPage/indexDetailsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { baseHeadingClasses } from "src/transactionsPage/transactionsPageClasses
import { CaretRight } from "../icon/caretRight";
import { BreadcrumbItem, Breadcrumbs } from "../breadcrumbs";
import { Caution, Search as IndexIcon } from "@cockroachlabs/icons";
import { SqlBox } from "src/sql";
import { SqlBox, SqlBoxSize } from "src/sql";
import { Col, Row, Tooltip } from "antd";
import "antd/lib/col/style";
import "antd/lib/row/style";
Expand Down Expand Up @@ -257,7 +257,10 @@ export class IndexDetailsPage extends React.Component<
<section className={baseHeadingClasses.wrapper}>
<Row gutter={18}>
<Col className="gutter-row" span={18}>
<SqlBox value={this.props.details.createStatement} />
<SqlBox
value={this.props.details.createStatement}
size={SqlBoxSize.custom}
/>
</Col>
</Row>
<Row gutter={18}>
Expand Down Expand Up @@ -306,7 +309,7 @@ export class IndexDetailsPage extends React.Component<
</SummaryCard>
</Col>
</Row>
<Row gutter={18}>
<Row gutter={18} className={cx("row-spaced")}>
<Col className="gutter-row" span={18}>
<SummaryCard className={cx("summary-card--row")}>
<Heading type="h5">Index recommendations</Heading>
Expand Down
2 changes: 1 addition & 1 deletion pkg/ui/workspaces/cluster-ui/src/statementDetails/statementDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ export class StatementDetails extends React.Component<
<Row gutter={24}>
<Col className="gutter-row" span={12}>
<BarGraphTimeSeries
title="Statement Execution and Planning Time"
title="Statement Times"
alignedData={executionAndPlanningTimeseries}
uPlotOptions={executionAndPlanningOps}
yAxisUnits={AxisUnits.Duration}
Expand Down