lease: revive TestLeaseAcquireAndReleaseConcurrencly #92679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajwerner
force-pushed
the
ajwerner/revive-TestLeaseAcquireAndReleaseConcurrencly
branch
from
c352d5b to
0c373a0
Compare
This test relied on an old placement of a testing knob (it's been moved back), and it relied on the leasing subsystem interacting with the lease table itself in interesting ways. We sidestep this latter bit by making the test use a new table. Lastly, we allow other concurrent leasing activity to not disturb the test. Fixes cockroachdb#51798 Release note: None
ajwerner
force-pushed
the
ajwerner/revive-TestLeaseAcquireAndReleaseConcurrencly
branch
from
0c373a0 to
2bd6fd2
Compare
|
This change is |
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relied on an old placement of a testing knob (it's been moved back), and it relied on the leasing subsystem interacting with the lease table itself in interesting ways. We sidestep this latter bit by making the test use a new table. Lastly, we allow other concurrent leasing activity to not disturb the test.
Fixes #51798
Release note: None