Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importer: use 1GiB max-sql-memory in a test #92678

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

yuzefovich
Copy link
Member

Fixes: #92225.

Release note: None

@yuzefovich yuzefovich requested review from adityamaru and a team November 29, 2022 17:54
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, seems like #91828 is a similar problem. i'll try this fix on that test too.

@yuzefovich
Copy link
Member Author

Hm, I wonder do we care enough to figure out why these two tests started flaking? It might be as simple as having better memory accounting in the import, or elsewhere in the system. Probably it's not worth the effort though.

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 29, 2022

Build succeeded:

@craig craig bot merged commit edc6fda into cockroachdb:master Nov 29, 2022
@yuzefovich yuzefovich deleted the import-monitor branch November 29, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/importer: TestImportDefaultWithResume failed
2 participants