-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: kvserver: lower score threshold for mvcc GC eligibility #92675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously GC score which is calculated based on average garbage age and percentage of live data was set to 2 to avoid frequent GC invocations. Value was set high in abundance of caution. Lowering it to 1 would guarantee that we would always collect something and not cause unnecessary frequent GC runs. To protect against unexpected situations where GC would be firing too frequently, cooldown period of 2 hours is added. This cooldown will apply from gc score of 1 and is decreased proportionally as score reaches 2 (the old threshold value). Release note (performance improvement): GC score triggering mvcc GC run is lowered. GC Score is ratio is computed from mvcc stats and uses ratio of live objects and estimated garbage age to estimate collectability of old data. Reduced score will trigger GC earlier lowering interval between runs 3 times, giving 2 times reduced peak garbage usage at the expense of 30% increase of wasteful data scanning on constantly updated data.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-92118
branch
2 times, most recently
from
November 29, 2022 16:23
734fe89
to
6761525
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Nov 29, 2022
erikgrinaker
approved these changes
Nov 30, 2022
CI build failure is known for the branch and is affecting old make build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #92118 on behalf of @aliher1911.
/cc @cockroachdb/release
Previously GC score which is calculated based on average garbage age and percentage of live data was set to 2 to avoid frequent GC invocations. Value was set high in abundance of caution.
Lowering it to 1 would guarantee that we would always collect something and not cause unnecessary frequent GC runs.
To protect against unexpected situations where GC would be firing too frequently, cooldown period of 2 hours is added. This cooldown will apply from gc score of 1 and is decreased proportionally as score reaches 2 (old threshold).
Release note (performance improvement): GC score triggering mvcc GC run is lowered. GC Score is ratio is computed from mvcc stats and uses ratio of live objects and estimated garbage age to estimate collectability of old data. Reduced score will trigger GC earlier lowering interval between runs 3 times, giving 2 times reduced peak garbage usage at the expense of 30% increase of wasteful data scanning on constantly updated data.
Fixes #38251
Release justification: Improvement required for existing client running on older version.