Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitenant: merge serverpb.RegionsServer into serverpb.TenantStatusServer #92599

Merged
merged 1 commit into from
Nov 28, 2022
Merged

multitenant: merge serverpb.RegionsServer into serverpb.TenantStatusServer #92599

merged 1 commit into from
Nov 28, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Nov 28, 2022

Fixes #92598

Merge these 2 interfaces in anticipation for future work where more tenant functionality will be added to TenantStatusServer instead of creating an interface per function.

Release note: None

@ecwall ecwall requested review from knz, dhartunian and rafiss November 28, 2022 18:48
@ecwall ecwall requested review from a team as code owners November 28, 2022 18:48
@ecwall ecwall requested a review from a team November 28, 2022 18:48
@ecwall ecwall requested review from a team as code owners November 28, 2022 18:48
@ecwall ecwall requested a review from a team November 28, 2022 18:48
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks

…erver

Fixes #92598

Merge these 2 interfaces in anticipation for future work where more tenant
functionality will be added to TenantStatusServer instead of creating an
interface per function.

Release note: None
@ecwall
Copy link
Contributor Author

ecwall commented Nov 28, 2022

bors r=knz

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@craig
Copy link
Contributor

craig bot commented Nov 28, 2022

Build succeeded:

@craig craig bot merged commit 1bc257b into cockroachdb:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multitenant: merge serverpb.RegionsServer into serverpb.TenantStatusServer
3 participants