-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix polling for statement and transaction details pages #92596
ui: fix polling for statement and transaction details pages #92596
Conversation
Resolved. |
This commit moves polling to the statement and transaction details page components from the cached data reducer and sagas, using the same approach as cockroachdb#85772. Fixes cockroachdb#91297. Release note (ui change): The statement fingerprint details page in the Console no longer infinitely loads after 5 minutes.
95cc8a7
to
e36a054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this need to be backported?
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)
TFTR!
Yes. Probably to 22.1 too. |
bors r+ |
bors cancel |
Canceled. |
bors r+ |
Build failed (retrying...): |
Build failed (retrying...): |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from e36a054 to blathers/backport-release-22.1-92596: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from e36a054 to blathers/backport-release-22.2-92596: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit moves polling to the statement and transaction details page components from the cached data reducer and sagas, using the same approach as #85772.
Fixes #91297.
Loom (DB Console and CC Console): https://www.loom.com/share/d3002ad54463448aaa3b8c9d74e31d10
Release note (ui change): The statement fingerprint details page in the Console no longer infinitely loads after 5 minutes.