Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix polling for statement and transaction details pages #92596

Merged

Conversation

ericharmeling
Copy link
Contributor

@ericharmeling ericharmeling commented Nov 28, 2022

This commit moves polling to the statement and transaction details page components from the cached data reducer and sagas, using the same approach as #85772.

Fixes #91297.

Loom (DB Console and CC Console): https://www.loom.com/share/d3002ad54463448aaa3b8c9d74e31d10

Release note (ui change): The statement fingerprint details page in the Console no longer infinitely loads after 5 minutes.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling
Copy link
Contributor Author

ericharmeling commented Nov 29, 2022

Running into the same error here as #90142, but finding it difficult to debug.

Resolved.

@ericharmeling ericharmeling marked this pull request as ready for review November 29, 2022 17:13
@ericharmeling ericharmeling marked this pull request as draft November 29, 2022 17:13
This commit moves polling to the statement and transaction
details page components from the cached data reducer and sagas,
using the same approach as cockroachdb#85772.

Fixes cockroachdb#91297.

Release note (ui change): The statement fingerprint details page in
the Console no longer infinitely loads after 5 minutes.
@ericharmeling ericharmeling force-pushed the fix-sql-activity-details-polling branch from 95cc8a7 to e36a054 Compare January 9, 2023 15:51
@ericharmeling ericharmeling marked this pull request as ready for review January 9, 2023 16:46
@ericharmeling ericharmeling requested review from a team and removed request for a team January 9, 2023 16:46
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

will this need to be backported?

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

@ericharmeling
Copy link
Contributor Author

TFTR!

will this need to be backported?

Yes. Probably to 22.1 too.

@ericharmeling
Copy link
Contributor Author

bors r+

@ericharmeling
Copy link
Contributor Author

bors cancel

@craig
Copy link
Contributor

craig bot commented Jan 9, 2023

Canceled.

@ericharmeling
Copy link
Contributor Author

ericharmeling commented Jan 9, 2023

Looks like a merge conflict with #92285 in the bors queue. Going to wait until #92285 is merged then rebase. Going to try merging this first, as #92285 is causing problems in the bors merge batch.

@ericharmeling
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 9, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jan 9, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jan 9, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jan 10, 2023

Build succeeded:

@craig craig bot merged commit b5cffc0 into cockroachdb:master Jan 10, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jan 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from e36a054 to blathers/backport-release-22.1-92596: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from e36a054 to blathers/backport-release-22.2-92596: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: SQL activity details page polling causes loading icon forever after 5 min
3 participants