Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix implicit txn flag in console #92408

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Nov 23, 2022

See: https://cockroachlabs.slack.com/archives/CPD3ANLMB/p1669224473591659
Epic: none

Release note (bug fix): Fixed the statement activity page so that it no longer shows multi-statement implicit transactions as "explicit."

@rafiss rafiss requested review from maryliag and a team November 23, 2022 19:29
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

Release note (bug fix): Fixed the statement activity page so that it no
longer shows multi-statement implicit transactions as "explicit."
@rafiss rafiss force-pushed the fix-implicit-txn-console branch from 832b651 to fbefe42 Compare November 23, 2022 20:29
@rafiss
Copy link
Collaborator Author

rafiss commented Nov 23, 2022

tftr!

bors r=maryliag

@craig
Copy link
Contributor

craig bot commented Nov 23, 2022

Build succeeded:

@craig craig bot merged commit b6c1555 into cockroachdb:master Nov 23, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 23, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from fbefe42 to blathers/backport-release-22.1-92408: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss rafiss deleted the fix-implicit-txn-console branch November 29, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants