instancestorage: load all regions from the system DB when reclaiming IDs #92248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jaylim-crl
force-pushed
the
jay/221121-instance-multiregion-enum
branch
3 times, most recently
from
23d39d7 to
b3b3bdd
Compare
|
Setting this as a draft to fix the tests. |
jaylim-crl
force-pushed
the
jay/221121-instance-multiregion-enum
branch
from
b3b3bdd to
1d09763
Compare
Follow up to cockroachdb#92010 and cockroachdb#91694. This commit addresses a TODO comment by loading all region enum members from the system database when reclaiming IDs. The list of regions is read each time the loop runs since there's a possibiilty where regions are added or removed from the system DB. Epic: None Release note: None
jaylim-crl
force-pushed
the
jay/221121-instance-multiregion-enum
branch
from
1d09763 to
2923074
Compare
|
TFTR! bors r=JeffSwenson |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #92010 and #91694.
This commit addresses a TODO comment by loading all region enum members from
the system database when reclaiming IDs. The list of regions is read each time
the loop runs since there's a possibiilty where regions are added or removed
from the system DB.
Epic: None
Release note: None