Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envutil: add GOMEMLIMIT to safeVarRegistry #92233

Merged

Conversation

nvanbenschoten
Copy link
Member

This commit adds the GOMEMLIMIT environment variable to the list of go runtime env vars that Cockroach will report about on the Node Diagnostics page. The original set was added in f6e2313. Since then, this is the only env var added to the go runtime.

Release note: None

Epic: None

This commit adds the GOMEMLIMIT environment variable to the list of go
runtime env vars that Cockroach will report about on the Node Diagnostics
page. The original set was added in f6e2313. Since then, this is the only
env var added to the go runtime.

Release note: None

Epic: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@nvanbenschoten
Copy link
Member Author

TFTR!

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Nov 21, 2022

Build succeeded:

@craig craig bot merged commit f0554bc into cockroachdb:master Nov 21, 2022
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/gomemlimitEnv branch November 21, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants