release-22.1: changefeedccl: fix handling of deletes in multi-column families #91953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #91870 on behalf of @HonoreDB.
/cc @cockroachdb/release
Fixes #91862
rowfetchers assume that a value with no column header must be for a single-column column family, for which the column header isn't needed. This doesn't reliably hold true in changefeeds, when such a value might also be a tombstone.
It looks like the only reason we never ran into this before is that if a column family has only one column, the rowfetcher won't throw an error in this situation as that column is set as the default.
Release note (bug fix): Fixed a bug causing changefeeds to fail when a value is deleted while running on a non-primary column family with multiple columns.
Release justification: Fixes a bug that can cause changefeeds to fail permanently even when running with on_error=pause.