Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: changefeedccl: fix handling of deletes in multi-column families #91953

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 15, 2022

Backport 1/1 commits from #91870 on behalf of @HonoreDB.

/cc @cockroachdb/release


Fixes #91862

rowfetchers assume that a value with no column header must be for a single-column column family, for which the column header isn't needed. This doesn't reliably hold true in changefeeds, when such a value might also be a tombstone.
It looks like the only reason we never ran into this before is that if a column family has only one column, the rowfetcher won't throw an error in this situation as that column is set as the default.

Release note (bug fix): Fixed a bug causing changefeeds to fail when a value is deleted while running on a non-primary column family with multiple columns.


Release justification: Fixes a bug that can cause changefeeds to fail permanently even when running with on_error=pause.

rowfetchers assume that a value with no column header must be for
a single-column column family, for which the column header isn't needed.
This doesn't reliably hold true in changefeeds, when such a value
might also be a tombstone.
It looks like the only reason we never ran into this before is that if a
column family has only one column, the rowfetcher won't throw an error in
this situation as that column is set as the default.

Release note (bug fix): Fixed a bug causing changefeeds to fail when a value is deleted while running on a non-primary column family with multiple columns.
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 15, 2022 22:48
@blathers-crl blathers-crl bot requested review from shermanCRL and removed request for a team November 15, 2022 22:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-91870 branch from 863c5e4 to 2d91ef0 Compare November 15, 2022 22:48
@blathers-crl blathers-crl bot requested a review from HonoreDB November 15, 2022 22:48
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 15, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@HonoreDB HonoreDB merged commit ba1d8e7 into release-22.1 Nov 21, 2022
@HonoreDB HonoreDB deleted the blathers/backport-release-22.1-91870 branch November 21, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants