catalog,tabledesc: tighten Constraint interface definition #91934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
postamar
force-pushed
the
constraint-interfaces
branch
2 times, most recently
from
8855f31 to
2c9661e
Compare
ajwerner
approved these changes
Nov 15, 2022
pkg/sql/schema_changer.go
Outdated
| @@ -2003,13 +2003,13 @@ func (sc *SchemaChanger) maybeReverseMutations(ctx context.Context, causingError | |||
| // If the mutation is for validating a constraint that is being added, | |||
| // drop the constraint because validation has failed. | |||
| if constraint := m.AsConstraint(); constraint != nil && constraint.Adding() { | |||
| log.Warningf(ctx, "dropping constraint %+v", constraint.ConstraintToUpdateDesc()) | |||
| log.Warningf(ctx, "dropping constraint %s", constraint.String()) | |||
There was a problem hiding this comment.
don't call String, as a habit it'll lead to immediate redaction
Release note: None
postamar
force-pushed
the
constraint-interfaces
branch
from
2c9661e to
f08db43
Compare
postamar
changed the title
|
Thanks for the review! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #91918.
Release note: None