changfeedccl: deflake TestAlterChangefeedTelemetry #91884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
miretskiy
approved these changes
Nov 15, 2022
The job system clears the lease asyncronously after cancelation. This lease clearing transaction can cause a restart in the alter changefeed transaction, which will lead to different feature counter counts. Thus, we want to wait for the lease clear. However, the lease clear isn't guaranteed to happen, so we only wait a few seconds for it. Release note: None
|
@miretskiy I pushed another commit to de-flake the test where I found this. Mind taking a look. |
stevendanna
changed the title
|
bors r+ I'm going to merge this to try to relieve the impact of the flake, we can follow up with a better fix if necessary. |
miretskiy
approved these changes
Nov 15, 2022
| // clear. However, the lease clear isn't guaranteed to | ||
| // happen, so we only wait a few seconds for it. | ||
| waitForNoLease := func() { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second) |
There was a problem hiding this comment.
Should the period be increased if under race?
helpers_test.go has withTimeout function that can help with this, plus assertPayloadsTimeout() is a helper that returns timeout adjusted for race (might need renaming)
|
bors r+ |
|
Build succeeded: |
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job system clears the lease asyncronously after cancelation. This
lease clearing transaction can cause a restart in the alter changefeed
transaction, which will lead to different feature counter
counts. Thus, we want to wait for the lease clear. However, the lease
clear isn't guaranteed to happen, so we only wait a few seconds for
it.
Epic: None
Release note: None