Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: make storage.mvcc.range_tombstones.enabled tenant-readable #91824

Merged
merged 1 commit into from
Nov 14, 2022
Merged

storage: make storage.mvcc.range_tombstones.enabled tenant-readable #91824

merged 1 commit into from
Nov 14, 2022

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Nov 14, 2022 •
edited
Loading

This setting needs to be readable by tenants, in order to be used by schema GC and import jobs.

Appropriate tests will be added separately.

Epic: CRDB-2624

Release note: None

@erikgrinaker erikgrinaker requested a review from a team as a code owner November 14, 2022 13:40
@erikgrinaker erikgrinaker self-assigned this Nov 14, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker
storage: make storage.mvcc.range_tombstones.enabled tenant-readable
61b3e60 
This setting needs to be readable by tenants, in order to be used by
schema GC and import jobs.

Appropriate tests will be added separately.

Release note: None
@erikgrinaker erikgrinaker force-pushed the mvcc-range-tombstones-tenant-readonly branch from 977fd1c to 61b3e60 Compare November 14, 2022 13:43
@stevendanna stevendanna mentioned this pull request Nov 14, 2022
Closed
stevendanna
stevendanna approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@stevendanna stevendanna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best we can probably do for now.

Note that operators will need to issue ALTER TENANT ALL SET CLUSTER SETTING ... in addition to SET CLUSTER SETTING to effectively change the value for everyone.

@erikgrinaker
Copy link
Contributor Author

Thanks for the heads-up.

CI failures are unrelated.

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 14, 2022

Build succeeded:

@craig craig bot merged commit 2e480d3 into cockroachdb:master Nov 14, 2022
@blathers-crl blathers-crl bot mentioned this pull request Nov 14, 2022
Merged
@erikgrinaker erikgrinaker deleted the mvcc-range-tombstones-tenant-readonly branch December 5, 2022 09:46
@erikgrinaker erikgrinaker mentioned this pull request Aug 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees

@erikgrinaker erikgrinaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikgrinaker @cockroach-teamcity @stevendanna