Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streampb: move out of CCL #91806

Merged
merged 1 commit into from
Nov 15, 2022
Merged

streampb: move out of CCL #91806

merged 1 commit into from
Nov 15, 2022

Conversation

stevendanna
Copy link
Collaborator

This moves streampb into pkg/streaming so that non-CCL code doesn't need to import CCL code.

It also renames pkg/streaming to pkg/repstream.

Fixes #91005

Release note: None

@stevendanna stevendanna requested a review from a team as a code owner November 13, 2022 13:44
@stevendanna stevendanna requested a review from a team November 13, 2022 13:44
@stevendanna stevendanna requested a review from a team as a code owner November 13, 2022 13:44
@stevendanna stevendanna requested review from rhu713 and removed request for a team November 13, 2022 13:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna requested a review from dt November 13, 2022 13:44
@adityamaru adityamaru self-requested a review November 13, 2022 20:12
adityamaru
adityamaru approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@adityamaru adityamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Whats the empty.go file about? Also should we rename streamingccl to repstreamccl in a future PR?

@stevendanna
Copy link
Collaborator Author

Whats the empty.go file about?

Looks like it was added in d9572ce to make sure there is always one go source file. We can probably remove it now that there is another non-pb-derived file in the package.

Also should we rename streamingccl to repstreamccl in a future PR?

🤷‍♂️ Happy to. I kinda don't love any of these names.

@stevendanna
streampb: move out of CCL
1ead23a 
This moves streampb into pkg/streaming so that non-CCL code doesn't
need to import CCL code.

It also renames pkg/streaming to pkg/repstream.

Fixes cockroachdb#91005

Release note: None
@stevendanna
Copy link
Collaborator Author

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Nov 15, 2022

Build succeeded:

@craig craig bot merged commit 03f6062 into cockroachdb:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru approved these changes

@rhu713 rhu713 Awaiting requested review from rhu713 rhu713 is a code owner automatically assigned from cockroachdb/disaster-recovery

@dt dt Awaiting requested review from dt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streamingccl/streampb: move out of ccl
3 participants
@stevendanna @cockroach-teamcity @adityamaru