Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: persistedsqlstats: skip logical_plan_sampling_for_explicit_txn #91683

Merged
merged 1 commit into from
Nov 10, 2022
Merged

release-22.2: persistedsqlstats: skip logical_plan_sampling_for_explicit_txn #91683

merged 1 commit into from
Nov 10, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 10, 2022 •
edited by ericharmeling
Loading

Backport 1/1 commits from #90744 on behalf of @adityamaru.

/cc @cockroachdb/release

Skipping the test since its flaky.

Informs: #89861

Release note: None

Release justification: non-production code changes

@adityamaru
persistedsqlstats: skip logical_plan_sampling_for_explicit_txn
1106366 
Skipping the test since its flaky.

Informs: #89861

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-90744 branch from 32907a3 to 1106366 Compare November 10, 2022 16:39
@blathers-crl blathers-crl bot requested a review from matthewtodd November 10, 2022 16:39
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 10, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 10, 2022 •
edited by ericharmeling
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling
Copy link
Contributor

This test is failing on the release-22.2 branch too https://cockroachlabs.slack.com/archives/C0159JK877C/p1668094035501089

@ericharmeling ericharmeling requested review from a team and removed request for matthewtodd November 10, 2022 16:40
maryliag
maryliag approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling)

@ericharmeling ericharmeling merged commit 6f3ec53 into release-22.2 Nov 10, 2022
@ericharmeling ericharmeling deleted the blathers/backport-release-22.2-90744 branch November 10, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryliag maryliag maryliag approved these changes

Assignees

@ericharmeling ericharmeling

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @ericharmeling @maryliag @adityamaru