release-22.2: colexec: protect columnarizer when closing not started input #91481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #91446 on behalf of @yuzefovich.
/cc @cockroachdb/release
This commit makes sure that the columnarizer calls
InternalClose
only if it has been initialized. Previously, ifColumnarizer.Init
wasn't performed (most likely due to a panic inInit
of another operator), the columnarizer's input would not be started, so whenInternalClose
calledinput.ConsumerClosed
, that could lead to a nil pointer panic sinceinput.Ctx
would benil
if the input tried to do some logging (some processors do that). We now protect against this by short-circuitingInternalClose
call altogether, similar to what we do inColumnarizer.DrainMeta
. This makes it so that the columnarizer satisfiesCloser.Close
contract properly.Fixes: #84902.
Release note: None
Release justification: bug fix.