Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server, ui: update prettify parameter #91214

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Nov 3, 2022

Previously, we were using PrettyAlignAndDeindent
parameter option for the usage of prettify_statement
on statement details endpoint and insights details
endpoints, which was subjected to a quadratic explosion.

This commit updates those uses to parameter
PrettyAlignOnly (1) on sql api and changes the
statement details endpoint to use the Go function of
Pretty instead, so it doesn't required a SQL
connection/execution.

Part Of #91197

Release note: None

@maryliag maryliag requested review from a team November 3, 2022 16:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag
Copy link
Contributor Author

maryliag commented Nov 3, 2022

I made some changes to account for the suggestions on the issue itself.
PTAL @xinhaoz

@maryliag maryliag requested a review from xinhaoz November 3, 2022 18:41
Previously, we were using `PrettyAlignAndDeindent`
parameter option for the usage of `prettify_statement`
on statement details endpoint and insights details
endpoints, which was subjected to a quadratic explosion.

This commit updates those uses to parameter
`PrettyAlignOnly` (1) on sql api and changes the
statement details endpoint to use the Go function of
Pretty instead, so it doesn't required a SQL
connection/execution.

Part Of cockroachdb#91197

Release note: None
@maryliag maryliag requested a review from a team November 3, 2022 20:10
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag
Copy link
Contributor Author

maryliag commented Nov 7, 2022

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 7, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Nov 8, 2022

Build succeeded:

@craig craig bot merged commit db8f691 into cockroachdb:master Nov 8, 2022
@blathers-crl
Copy link

blathers-crl bot commented Nov 8, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d37e37e to blathers/backport-release-22.1-91214: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants