-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server, ui: update prettify parameter #91214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
23bf219
to
b081147
Compare
I made some changes to account for the suggestions on the issue itself. |
b081147
to
d9b4eef
Compare
Previously, we were using `PrettyAlignAndDeindent` parameter option for the usage of `prettify_statement` on statement details endpoint and insights details endpoints, which was subjected to a quadratic explosion. This commit updates those uses to parameter `PrettyAlignOnly` (1) on sql api and changes the statement details endpoint to use the Go function of Pretty instead, so it doesn't required a SQL connection/execution. Part Of cockroachdb#91197 Release note: None
d9b4eef
to
d37e37e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
bors r+ |
Build failed (retrying...): |
Build failed (retrying...): |
Build failed (retrying...): |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d37e37e to blathers/backport-release-22.1-91214: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, we were using
PrettyAlignAndDeindent
parameter option for the usage of
prettify_statement
on statement details endpoint and insights details
endpoints, which was subjected to a quadratic explosion.
This commit updates those uses to parameter
PrettyAlignOnly
(1) on sql api and changes thestatement details endpoint to use the Go function of
Pretty instead, so it doesn't required a SQL
connection/execution.
Part Of #91197
Release note: None