spanconfigsqltranslator: translate spanconfigs for offline dbs #91173
Conversation
|
This change is |
There was a problem hiding this comment.
Do you think it's worth adding a test where we try to add a PTS for an offline database as well, given that's what the issue describes?
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
Previously, we would ignore sql updates for databases that are offline. As explained in cockroachdb#91148 in some situations we require writing a protected timestamp to an offline database during a restore. This will require the spanconfig machinery to reconcile the PTS record so that the GC queue can observe and respect it. We already reconcile sql udpates for offline tables so it seems reasonable to do the same for offline databases. Fixes: cockroachdb#91149 Release note: None
adityamaru
force-pushed
the
offline-scfg
branch
from
9150a84 to
fa09e28
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from fa09e28 to blathers/backport-release-22.1-91173: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, we would ignore sql updates for databases that are offline. As explained in #91148 in some situations we require writing a protected timestamp to an offline database during a restore. This will require the spanconfig machinery to reconcile the PTS record so that the GC queue can observe and respect it.
We already reconcile sql udpates for offline tables so it seems reasonable to do the same for offline databases.
Fixes: #91149
Release note: None