Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: storage: adjust range tombstone language to encourage caution #91095

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 1, 2022

Backport 1/1 commits from #91011 on behalf of @jbowens.

/cc @cockroachdb/release


Adjust the MVCC range tombstone cluster setting description to highlight its experimental nature and to be appropriately cautious about the consequence of enabling range tombstones.

Cockroach 22.2.0 will ship with the cluster setting and likely at least one bug that may induce corruption if the setting is enabled (#90948).

Epic: None
Release note: None
Release justification: documentation change only
Close #91001.

Adjust the MVCC range tombstone cluster setting description to highlight
its experimental nature and to be appropriately cautious about the
consequence of enabling range tombstones.

Cockroach 22.2.0 will ship with the cluster setting and likely at least
one bug that may induce corruption if the setting is enabled
(#90948).

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 1, 2022 21:09
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-91011 branch from ce85774 to d1c8846 Compare November 1, 2022 21:09
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 1, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from nicktrav November 1, 2022 21:09
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 1, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav
Copy link
Collaborator

nicktrav commented Nov 1, 2022

LGTM.

@erikgrinaker
Copy link
Contributor

Taking the liberty of merging this.

@erikgrinaker erikgrinaker merged commit 0713a2c into release-22.2 Nov 14, 2022
@erikgrinaker erikgrinaker deleted the blathers/backport-release-22.2-91011 branch November 14, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants