upgrades,sql: alter system.comments table primary key #91060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Part of cockroachdb#88571 We need to read and write `system.comments` through `kv.Batch` if we want extend the `uncommitted` layer of collection to cache original comments and changes to comments, and be able to write changes to comments together with other mutations to descriptor in same transaction. To achieve that it'd be more convenient to have the descriptor id as the first column of primary key, so that we can construct a kv key like `/commentsTableID/descID` to fetch all comments of an object. Otherwise we'd need to loop through all comment types. We're lucky that none of the existing code really rely on the old primary key column order. Release note: None
chengxiong-ruan
force-pushed
the
alter-system-comments-primary-key
branch
from
3d76422 to
95baec0
Compare
|
hmmm...altering a primary key creates a new primary key but with different index id, which means pk index id would be different between clusters upgraded to this version and clusters bootstrapped with this version >_> . This would make the kv scan/write confusing. I can live with the old primary key. Closing this PR.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #88571
We need to read and write
system.commentsthroughkv.Batchif we want extend theuncommittedlayer of collection to cache original comments and changes to comments, and be able to write changes to comments together with other mutations to descriptor in same transaction. To achieve that it'd be more convenient to have the descriptor id as the first column of primary key, so that we can construct a kv key like/commentsTableID/descIDto fetch all comments of an object. Otherwise we'd need to loop through all comment types.We're lucky that none of the existing code really rely on the old primary key column order.
Release note: None